[webkit-reviews] review granted: [Bug 189232] REGRESSION (r191336): RenderFlexibleBox::adjustChildSizeForMinAndMax crashes in std::optional<>::value() : [Attachment 348734] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted zalan <zalan at apple.com>'s
request for review:
Bug 189232: REGRESSION (r191336):
RenderFlexibleBox::adjustChildSizeForMinAndMax crashes in
std::optional<>::value()
https://bugs.webkit.org/show_bug.cgi?id=189232

Attachment 348734: Patch

https://bugs.webkit.org/attachment.cgi?id=348734&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 348734
  --> https://bugs.webkit.org/attachment.cgi?id=348734
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348734&action=review

R=me

> Source/WebCore/ChangeLog:12
> +	   ensure valid values through the virtual calls of
computeIntrinsicLogicalContentHeightUsing.

What symptom should we look for if these are expected to be valid? Should we
have QA keep an eye out for anything in particular?