[webkit-reviews] review granted: [Bug 191114] API test WKAttachmentTests.CopyAndPasteBetweenWebViews fails on macOS 10.13 : [Attachment 353563] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 191114: API test WKAttachmentTests.CopyAndPasteBetweenWebViews fails on
macOS 10.13
https://bugs.webkit.org/show_bug.cgi?id=191114

Attachment 353563: Patch

https://bugs.webkit.org/attachment.cgi?id=353563&action=review




--- Comment #11 from Dean Jackson <dino at apple.com> ---
Comment on attachment 353563
  --> https://bugs.webkit.org/attachment.cgi?id=353563
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353563&action=review

> Source/WebKit/ChangeLog:9
> +	   Followup to r237648: also make sure that we unsecurely unarchive
NSFileWrapper on platforms that don't support

typo: unsecurely

> Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm:161
> +    NSFileWrapper *fileWrapper =
insecurelyUnarchiveObjectFromData(serializedData.get());

Isn't this insecure? :)