[webkit-reviews] review granted: [Bug 191141] Forward original fragment identifier into System Preview : [Attachment 353561] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 191141: Forward original fragment identifier into System Preview
https://bugs.webkit.org/show_bug.cgi?id=191141

Attachment 353561: Patch

https://bugs.webkit.org/attachment.cgi?id=353561&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 353561
  --> https://bugs.webkit.org/attachment.cgi?id=353561
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353561&action=review

r=mews

> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:108
> +- (void)finish:(WebCore::URL)url
withFragmentIdentifier:(NSString*)fragmentIdentifier

Nit - NSString *

> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:114
> +	       self.completionHandler([NSURL URLWithString:[NSString
stringWithFormat:@"%@#%@", (NSString*)url.string(),
(NSString*)fragmentIdentifier]], nil);

Nit - More NSString *

Instead of passing the fragment separately, would it be cleaner to just use
URL::setFragmentIdentifier on the destinationURL?