[webkit-reviews] review requested: [Bug 191124] Cleanup: Extraneous platform guarding of -_setUpSQLiteDatabaseTrackerClient : [Attachment 353512] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 191124: Cleanup: Extraneous platform guarding of
-_setUpSQLiteDatabaseTrackerClient
https://bugs.webkit.org/show_bug.cgi?id=191124

Attachment 353512: Patch

https://bugs.webkit.org/attachment.cgi?id=353512&action=review




--- Comment #1 from Daniel Bates <dbates at webkit.org> ---
Created attachment 353512

  --> https://bugs.webkit.org/attachment.cgi?id=353512&action=review

Patch

Let me know if it is preferred to keep the guards around the function call and
move the guards in the implementation to be surrounding the implementation.
With the guards removed from the call site, I would hope that the compiler is
smart enough to realize that the called function is empty and just elide the
function call. Maybe this is not true (I haven't looked at the binary) or maybe
we have compiler warnings enabled to catch empty functions (I also haven't
looked)?