[webkit-reviews] review granted: [Bug 191115] Adjust inlining threshold for new bytecode format : [Attachment 353494] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 191115: Adjust inlining threshold for new bytecode format
https://bugs.webkit.org/show_bug.cgi?id=191115

Attachment 353494: Patch

https://bugs.webkit.org/attachment.cgi?id=353494&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 353494
  --> https://bugs.webkit.org/attachment.cgi?id=353494
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353494&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +	   The new format changed the number of operands for many opcodes,
which

I think it's worth noting that you often made it so we had fewer operands, not
more.

> Source/JavaScriptCore/runtime/Options.h:306
> +    v(unsigned, maximumFunctionForCallInlineCandidateInstructionCount, 120,
Normal, nullptr) \

I wonder if this obviates that test you just added.