[webkit-reviews] review granted: [Bug 190853] Web Inspector: Audit: show metadata for results : [Attachment 353471] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 190853: Web Inspector: Audit: show metadata for results
https://bugs.webkit.org/show_bug.cgi?id=190853

Attachment 353471: Patch

https://bugs.webkit.org/attachment.cgi?id=353471&action=review




--- Comment #9 from Brian Burg <bburg at apple.com> ---
Comment on attachment 353471
  --> https://bugs.webkit.org/attachment.cgi?id=353471
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353471&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/AuditTestCase.js:116
> +	       let evaluateResponse = await
RuntimeAgent.evaluate.invoke(evaluateArguments);

Nit: better name is evaluateResult or evaluationResult.

> Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.js:109
> +		       durationElement.textContent =
Number.secondsToString((metadata.endTimestamp - metadata.startTimestamp) /
1000);

The .00 after every duration is kind of ugly. I thought that
Number.secondsToString would have elided that rather than add fake precision.

> Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.css:59
> +    --metadata-width: 60px;

This could be brittle for localization, so we have to fix later.