[webkit-reviews] review granted: [Bug 191112] [MediaStream] Don't reveal device IDs until the user has granted permission to capture : [Attachment 353496] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 191112: [MediaStream] Don't reveal device IDs until the user has granted
permission to capture
https://bugs.webkit.org/show_bug.cgi?id=191112

Attachment 353496: Patch

https://bugs.webkit.org/attachment.cgi?id=353496&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 353496
  --> https://bugs.webkit.org/attachment.cgi?id=353496
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353496&action=review

> LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html:90
> +		       .then(stream => mediaStream = stream);

mediaStream = await navigator.mediaDevices.getUserMedia({ audio:true,
video:true });

> LayoutTests/fast/mediastream/get-user-media-device-id.html:18
> +		       assert_true(device.deviceId.length == 0 ,
"device.deviceId is empty before permission to capture");

Should we go with empty device ids or undefined device ids?
The spec seems to forbid empty device ids as they must be unique.
In terms of breakage, empty string device ids might be a bit better except if
used for hashes.