[webkit-reviews] review granted: [Bug 191110] [GTK][WPE] Remaining topPrivatelyControlledDomain() fixes : [Attachment 353485] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 191110: [GTK][WPE] Remaining topPrivatelyControlledDomain() fixes
https://bugs.webkit.org/show_bug.cgi?id=191110

Attachment 353485: Patch

https://bugs.webkit.org/attachment.cgi?id=353485&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 353485
  --> https://bugs.webkit.org/attachment.cgi?id=353485
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353485&action=review

Specifically, what tests is it fixing?

> Source/WebCore/platform/soup/PublicSuffixSoup.cpp:49
> +    if (!domain.isAllASCII())
> +	   return domain;

Syncing with the Mac implementation seems most important, but now can't the
function return a domain that is not the top privately-controlled domain?