[webkit-reviews] review granted: [Bug 190778] MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called : [Attachment 353421] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Wendy <yuhan_wu at apple.com>'s
request for review:
Bug 190778: MediaRecorder should fire dataavailable event when all tracks are
ended and stop() is called
https://bugs.webkit.org/show_bug.cgi?id=190778

Attachment 353421: Patch

https://bugs.webkit.org/attachment.cgi?id=353421&action=review




--- Comment #46 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 353421
  --> https://bugs.webkit.org/attachment.cgi?id=353421
Patch

LGTM.

View in context: https://bugs.webkit.org/attachment.cgi?id=353421&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:169
>	       return;

We probably do not need that check, it seems that the given function will in
most case do a check on its state().