[webkit-reviews] review requested: [Bug 191037] Web Inspector: Styles: implement copying and deletion of multiple properties : [Attachment 353451] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has asked  for review:
Bug 191037: Web Inspector: Styles: implement copying and deletion of multiple
properties
https://bugs.webkit.org/show_bug.cgi?id=191037

Attachment 353451: Patch

https://bugs.webkit.org/attachment.cgi?id=353451&action=review




--- Comment #6 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 353451

  --> https://bugs.webkit.org/attachment.cgi?id=353451&action=review

Patch

(In reply to Devin Rousso from comment #4)
> Comment on attachment 353307 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353307&action=review
> 
> r-, as there is some funky stuff happening with `tabindex` that needs some
> explanation

tabIndex is always -1 now.

> Also, I've encountered a few "bugs":
>  - starting a selection on the first property of a style and dragging up
> (outside of that style) will add a property to the end after mouseup
>  - I am able to continue "selecting" past the last property of a section,
> even going so far as to select "User Agent Stylesheet"

I fixed this one. I plan to fix the rest as a follow-up.

>  - the selection background doesn't appear until I drag to another property,
> meaning that for rules with one style, I'm unable to select it by dragging
> sideways
>  - tabbing doesn't work after selecting more than one property