[webkit-reviews] review granted: [Bug 191072] [PlayStation] Enable JavaScriptCore : [Attachment 353429] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 30 17:17:18 PDT 2018

Brent Fulgham <bfulgham at webkit.org> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 191072: [PlayStation] Enable JavaScriptCore

Attachment 353429: Patch


--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 353429
  --> https://bugs.webkit.org/attachment.cgi?id=353429

View in context: https://bugs.webkit.org/attachment.cgi?id=353429&action=review

These changes all seem well isolated to the PlayStation port. I don't see any
reason why this would pose a problem to land, assuming the build system is

> CMakeLists.txt:43
> +    PlayStation


> Tools/Scripts/webkitdirs.pm:2310
> +	   push @args, '-G "Visual Studio 15"';

Does the PS build not support VS 2017?

More information about the webkit-reviews mailing list