[webkit-reviews] review granted: [Bug 190530] [Cocoa] Attachment dropped from one web view to another is missing its file wrapper : [Attachment 353435] Try to fix the Windows build

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 190530: [Cocoa] Attachment dropped from one web view to another is missing
its file wrapper
https://bugs.webkit.org/show_bug.cgi?id=190530

Attachment 353435: Try to fix the Windows build

https://bugs.webkit.org/attachment.cgi?id=353435&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 353435
  --> https://bugs.webkit.org/attachment.cgi?id=353435
Try to fix the Windows build

View in context: https://bugs.webkit.org/attachment.cgi?id=353435&action=review

> Source/WebCore/html/HTMLAttachmentElement.cpp:91
> +    return URLParser(makeString("applewebdata://attachment/"_s,
identifier)).result();

It feels weird/scary to build a URL by concatenating strings. But it seems like
we don't have a mutable URL? What happens if identifier (which comes from
where?) has non-path-safe characters?