[webkit-reviews] review requested: [Bug 190487] [iOS] WebKit should dispatch DOM events when a modifier key is pressed : [Attachment 353432] Patch and test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 30 16:40:16 PDT 2018
Daniel Bates <dbates at webkit.org> has asked for review:
Bug 190487: [iOS] WebKit should dispatch DOM events when a modifier key is
pressed
https://bugs.webkit.org/show_bug.cgi?id=190487
Attachment 353432: Patch and test
https://bugs.webkit.org/attachment.cgi?id=353432&action=review
--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Created attachment 353432
--> https://bugs.webkit.org/attachment.cgi?id=353432&action=review
Patch and test
Updated patch a similar change to -[WebEvent
initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers
:isRepeating:withFlags:withInputManagerHint:keyCode:isTabKey:] as I did for
-[WebEvent
initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers
:isRepeating:withFlags:keyCode:isTabKey:characterSet:].
More information about the webkit-reviews
mailing list