[webkit-reviews] review granted: [Bug 190754] Web Inspector: Audit: create Audit Tab : [Attachment 353404] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 190754: Web Inspector: Audit: create Audit Tab
https://bugs.webkit.org/show_bug.cgi?id=190754

Attachment 353404: Patch

https://bugs.webkit.org/attachment.cgi?id=353404&action=review




--- Comment #22 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 353404
  --> https://bugs.webkit.org/attachment.cgi?id=353404
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353404&action=review

r=me. This looks great!

- Nice code cleanup/design
- Dark Mode looks great
- Love the new icons

> Source/WebInspectorUI/ChangeLog:70
> +	   * UserInterface/Models/AuditTestBase.js: Added.

Nice design!

> Source/WebInspectorUI/UserInterface/Models/AuditTestBase.js:89
> +	      
this.dispatchEventToListeners(WI.AuditTestBase.Event.ResultCleared);

I think an options object is unnecessary. Isn't `suppressResultClearedEvent`
the only option? If so it should be an argument.