[webkit-reviews] review granted: [Bug 191062] Align entries in metadata table : [Attachment 353371] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Dominik Inführ
<dinfuehr at igalia.com>'s request for review:
Bug 191062: Align entries in metadata table
https://bugs.webkit.org/show_bug.cgi?id=191062

Attachment 353371: Patch

https://bugs.webkit.org/attachment.cgi?id=353371&action=review




--- Comment #8 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 353371
  --> https://bugs.webkit.org/attachment.cgi?id=353371
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353371&action=review

> Source/JavaScriptCore/bytecode/Opcode.cpp:202
> +static unsigned metadataAlignments[] = {
> +
> +#define METADATA_ALIGNMENT(size) size,
> +    FOR_EACH_BYTECODE_METADATA_ALIGNMENT(METADATA_ALIGNMENT)
> +#undef METADATA_ALIGNMENT
> +
> +};

This data is not necessary if `CPU(NEEDS_ALIGNED_ACCESS)` is false. Let's guard
with this condition and drop this data from the binary.

> Source/JavaScriptCore/bytecode/Opcode.cpp:212
> +unsigned metadataAlignment(OpcodeID opcodeID)
> +{
> +    return metadataAlignments[opcodeID];
> +}

Ditto.