[webkit-reviews] review granted: [Bug 190987] Web Inspector: provide options to WI.cssPath for more verbosity : [Attachment 353345] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 190987: Web Inspector: provide options to WI.cssPath for more verbosity
https://bugs.webkit.org/show_bug.cgi?id=190987

Attachment 353345: Patch

https://bugs.webkit.org/attachment.cgi?id=353345&action=review




--- Comment #5 from Brian Burg <bburg at apple.com> ---
Comment on attachment 353345
  --> https://bugs.webkit.org/attachment.cgi?id=353345
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353345&action=review

r=me

> Source/WebInspectorUI/ChangeLog:8
> +	   * UserInterface/Base/DOMUtilities.js:

You need to describe the enhancements being made here.

> Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js:138
> +	       let unique = new Map;

Nit: uniqueAttributes

> LayoutTests/inspector/dom/domutilities-csspath.html:10
> +    async function nodeForSelector(selector) {

v.nice!