[webkit-reviews] review granted: [Bug 190956] [WPE][GTK] Certificates loaded from the cache don't include the certificate chain : [Attachment 353373] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 190956: [WPE][GTK] Certificates loaded from the cache don't include the
certificate chain
https://bugs.webkit.org/show_bug.cgi?id=190956

Attachment 353373: Patch

https://bugs.webkit.org/attachment.cgi?id=353373&action=review




--- Comment #21 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 353373
  --> https://bugs.webkit.org/attachment.cgi?id=353373
Patch

LGTM, it would be good to have another LGTM from soup side.

As of the refactoring for sharing with IPC, maybe a templated encode/decode
routine could be added to CertificateInfo directly.
Some unit test might be feasible, especially if that was a source of issues in
the past.

View in context: https://bugs.webkit.org/attachment.cgi?id=353373&action=review

> Source/WebKit/NetworkProcess/cache/NetworkCacheCodersSoup.cpp:90
> +   
certificateInfo.setCertificate(certificateFromCertificatesDataList(certificates
DataList).get());

Should setCertificate take a GRefPtr<>&&?