[webkit-reviews] review granted: [Bug 190946] [EME][Cocoa] Cannot play unmuxed video and audio fMP4 streams encrypted with different keys via MSE : [Attachment 353297] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 190946: [EME][Cocoa] Cannot play unmuxed video and audio fMP4 streams
encrypted with different keys via MSE
https://bugs.webkit.org/show_bug.cgi?id=190946

Attachment 353297: Patch

https://bugs.webkit.org/attachment.cgi?id=353297&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 353297
  --> https://bugs.webkit.org/attachment.cgi?id=353297
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353297&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreaming
AVFObjC.h:108
> +    AVContentKeySession* contentKeySession() { return m_session.get(); }

Can m_session ever be null? If so, should you return ensureSession() instead?