[webkit-reviews] review granted: [Bug 191021] Web Inspector: Styles: missing contextmenu items for links : [Attachment 353277] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 191021: Web Inspector: Styles: missing contextmenu items for links
https://bugs.webkit.org/show_bug.cgi?id=191021

Attachment 353277: Patch

https://bugs.webkit.org/attachment.cgi?id=353277&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 353277
  --> https://bugs.webkit.org/attachment.cgi?id=353277
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353277&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:97
>      contextMenu.appendItem(WI.UIString("Open in New Tab"), () => {

Hmm, Safari doesn't show "Open in New Tab" if the link is a `javascript:` link.
I think we should probably do the same for `javascript:` / `data:` and maybe
all non-http/https links.

> Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:117
>      contextMenu.appendItem(WI.UIString("Copy Link Address"), () => {

Hmm, Safari shows "Copy Link" instead of "Copy Link Address". I think we should
probably update our text.

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:708
> +	   WI.appendContextMenuItemsForURL(contextMenu, token.value);

Does this work with both an absolute and relative URL?