[webkit-reviews] review granted: [Bug 190936] Add a deprecation warning to console for Web SQL : [Attachment 353292] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 29 15:02:27 PDT 2018


Ryosuke Niwa <rniwa at webkit.org> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 190936: Add a deprecation warning to console for Web SQL
https://bugs.webkit.org/show_bug.cgi?id=190936

Attachment 353292: Patch

https://bugs.webkit.org/attachment.cgi?id=353292&action=review




--- Comment #24 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 353292
  --> https://bugs.webkit.org/attachment.cgi?id=353292
Patch

So I think our typical message is that "X is deprecated. Please use Y instead".
See examples for ApplicationCache, CSSKeyframesRule::insertRule,
XMLHttpRequest::send(ArrayBuffer&), etc...
For consistency, we should do the same.

r=me with that message change.


More information about the webkit-reviews mailing list