[webkit-reviews] review granted: [Bug 191026] LibWebRTCRtpReceiverBackend::getSynchronizationSources should use Vector::append : [Attachment 353289] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 29 11:30:00 PDT 2018


Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 191026: LibWebRTCRtpReceiverBackend::getSynchronizationSources should use
Vector::append
https://bugs.webkit.org/show_bug.cgi?id=191026

Attachment 353289: Patch

https://bugs.webkit.org/attachment.cgi?id=353289&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 353289
  --> https://bugs.webkit.org/attachment.cgi?id=353289
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353289&action=review

> LayoutTests/webrtc/video-addTransceiver.html:114
> +    if (sources.length) {

Why do this test, shouldn't it be the same from run to run?


More information about the webkit-reviews mailing list