[webkit-reviews] review granted: [Bug 190998] [LFC][IFC] Add support for simple intruding floats. : [Attachment 353249] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 190998: [LFC][IFC] Add support for simple intruding floats.
https://bugs.webkit.org/show_bug.cgi?id=190998

Attachment 353249: Patch

https://bugs.webkit.org/attachment.cgi?id=353249&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 353249
  --> https://bugs.webkit.org/attachment.cgi?id=353249
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353249&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:246
> +    // For formatting roots, we already precomputed final position.

Should we assert that?

> Source/WebCore/layout/floats/FloatingState.cpp:115
> -	   if (!(rect.top() <= verticalPosition && verticalPosition <
rect.bottom()))
> +	   if (!(rect.top() <= adjustedPosition.y && adjustedPosition.y <
rect.bottom()))
>	       continue;

Ninja fix?