[webkit-reviews] review denied: [Bug 190977] '-webkit-user-select: all' is not respected in editable views : [Attachment 353209] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Tim Horton <thorton at apple.com>'s
request for review:
Bug 190977: '-webkit-user-select: all' is not respected in editable views
https://bugs.webkit.org/show_bug.cgi?id=190977

Attachment 353209: Patch

https://bugs.webkit.org/attachment.cgi?id=353209&action=review




--- Comment #19 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 353209
  --> https://bugs.webkit.org/attachment.cgi?id=353209
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353209&action=review

> Source/WebCore/dom/Node.cpp:751
> +	   if (documentIsEditable)
> +	       return Node::Editability::CanEditRichly;
> +

This isn't right. It's totally possible to have -webkit-user-modify: read-only
inside a design mode document.
As done in editabilityFromContentEditableAttr, we need to wait until we get out
of this loop.
r- because of this and the test failures.