[webkit-reviews] review granted: [Bug 190954] CRASH in CoreGraphics: ERROR_CGDataProvider_BufferIsNotBigEnough : [Attachment 353184] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 190954: CRASH in CoreGraphics: ERROR_CGDataProvider_BufferIsNotBigEnough
https://bugs.webkit.org/show_bug.cgi?id=190954

Attachment 353184: Patch

https://bugs.webkit.org/attachment.cgi?id=353184&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 353184
  --> https://bugs.webkit.org/attachment.cgi?id=353184
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353184&action=review

> Source/WebCore/platform/graphics/cg/ImageUtilitiesCG.h:32
> +inline uint8_t verifyImageBufferIsBigEnough(const void* buffer, size_t
bufferSize)

This function isn't really specific to image buffers so the filename seems
oddly specific, but hopefully it's temporary.

> Source/WebCore/platform/graphics/cg/ImageUtilitiesCG.h:40
> +    return *(uint8_t*)lastByte;

Might the compiler optimize that away since no callers use the return value?