[webkit-reviews] review granted: [Bug 190996] [Web Animations] Move bindings methods requiring style flush from CSSAnimation to DeclarativeAnimation : [Attachment 353246] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 27 14:04:09 PDT 2018
Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 190996: [Web Animations] Move bindings methods requiring style flush from
CSSAnimation to DeclarativeAnimation
https://bugs.webkit.org/show_bug.cgi?id=190996
Attachment 353246: Patch
https://bugs.webkit.org/attachment.cgi?id=353246&action=review
--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 353246
--> https://bugs.webkit.org/attachment.cgi?id=353246
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=353246&action=review
> Source/WebCore/animation/CSSAnimation.cpp:-126
> - auto currentTime = DeclarativeAnimation::bindingsCurrentTime();
> - if (currentTime) {
> - if (auto* animationEffect = effect())
> - return std::max(0.0, std::min(currentTime.value(),
animationEffect->timing()->activeDuration().milliseconds()));
> - }
> - return currentTime;
is this logic in WebAnimation::bindingsCurrentTime?
More information about the webkit-reviews
mailing list