[webkit-reviews] review granted: [Bug 190893] [MSE][WTF][Media] Invalid MediaTime should be falsy : [Attachment 353066] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 26 05:31:58 PDT 2018


Jer Noble <jer.noble at apple.com> has granted Alicia Boya GarcĂ­a
<aboya at igalia.com>'s request for review:
Bug 190893: [MSE][WTF][Media] Invalid MediaTime should be falsy
https://bugs.webkit.org/show_bug.cgi?id=190893

Attachment 353066: Patch

https://bugs.webkit.org/attachment.cgi?id=353066&action=review




--- Comment #2 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 353066
  --> https://bugs.webkit.org/attachment.cgi?id=353066
Patch

Originally, I decided not to make isInvalid() false because I thought it would
be weird to have !isInvalid() == !zero.  But I see that floating point NaN is
also falsy, so this LGTM.


More information about the webkit-reviews mailing list