[webkit-reviews] review canceled: [Bug 66381] Web Inspector: support multiple selection/deletion of cookie records : [Attachment 353102] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 25 22:40:32 PDT 2018


Devin Rousso <drousso at apple.com> has canceled  review:
Bug 66381: Web Inspector: support multiple selection/deletion of cookie records
https://bugs.webkit.org/show_bug.cgi?id=66381

Attachment 353102: Patch

https://bugs.webkit.org/attachment.cgi?id=353102&action=review




--- Comment #13 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 353102
  --> https://bugs.webkit.org/attachment.cgi?id=353102
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353102&action=review

>> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:268
>> +		this._cookies = this._filterCookies(payload.cookies);
> 
> You need to resort this based on the current sort.

Just saw that attachment 353155 fixes this.  My mistake :P


More information about the webkit-reviews mailing list