[webkit-reviews] review granted: [Bug 190922] JSContext Inspector: Broken frontend, DOMAgent is used but does not exist : [Attachment 353120] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 190922: JSContext Inspector: Broken frontend, DOMAgent is used but does not
exist
https://bugs.webkit.org/show_bug.cgi?id=190922

Attachment 353120: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=353120&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 353120
  --> https://bugs.webkit.org/attachment.cgi?id=353120
[PATCH] Proposed Fix

r=me

While I do think this is a valid solution, I think it would better to wrap the
`ensureDocument` call in a similar if (or even introduce a
`WI.DOMManager.supported()` like some other managers).	I'd prefer to check for
support at the construction point rather than right before the call.