[webkit-reviews] review granted: [Bug 190819] Cleanup: inline constexpr is redundant as constexpr implies inline : [Attachment 353108] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 190819: Cleanup: inline constexpr is redundant as constexpr implies inline
https://bugs.webkit.org/show_bug.cgi?id=190819

Attachment 353108: Patch

https://bugs.webkit.org/attachment.cgi?id=353108&action=review




--- Comment #7 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 353108
  --> https://bugs.webkit.org/attachment.cgi?id=353108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353108&action=review

r=me

>>> Source/JavaScriptCore/ChangeLog:3
>>> +	     Cleanup: inline constexpr is redundant as constexpr implies inline
>> 
>> Are you sure that this is true?  constexpr functions may be called on none
const arguments, and therefore produce a non-constexpr value.  Marking a
function constexpr only means that it *can* produce a constexpr value, not
necessarily that it *will* produce a constexpr value.  Hence, I'm not sure that
constexpr necessarily means the function will be inlined.  At least that's my
understanding.	Am I wrong?
> 
> According to https://en.cppreference.com/w/cpp/language/constexpr:

Excellent.