[webkit-reviews] review denied: [Bug 190912] http/wpt/cache-storage/cache-quota.any.html is failing : [Attachment 353098] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has denied darshan
<dkadu at igalia.com>'s request for review:
Bug 190912: http/wpt/cache-storage/cache-quota.any.html is failing
https://bugs.webkit.org/show_bug.cgi?id=190912

Attachment 353098: Patch

https://bugs.webkit.org/attachment.cgi?id=353098&action=review




--- Comment #2 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 353098
  --> https://bugs.webkit.org/attachment.cgi?id=353098
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353098&action=review

You need to remove the failures from LayoutTests/platform/gtk/TestExpectations
and LayoutTests/platform/wpe/TestExpectations. Let's do that on bug 178316
directly.

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h:116
> +WK_EXPORT void WKWebsiteDataStoreSetQuota(WKWebsiteDataStoreRef
dataStoreRef, uint64_t quota);

I'm not familiar with the rules to introduce new API, so let's see what other
reviewers say.

> Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:117
> +    WKWebsiteDataStoreSetQuota(websiteDataStore, 400 * 1024);

I think you should do the same for WPE.