[webkit-reviews] review granted: [Bug 190879] [PSON] Avoid tearing down the drawing area when suspending a WebPage due to process-swap : [Attachment 353050] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 190879: [PSON] Avoid tearing down the drawing area when suspending a
WebPage due to process-swap
https://bugs.webkit.org/show_bug.cgi?id=190879

Attachment 353050: Patch

https://bugs.webkit.org/attachment.cgi?id=353050&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 353050
  --> https://bugs.webkit.org/attachment.cgi?id=353050
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353050&action=review

Which mechanism guarantees that we don't use memory for any tiles in suspended
process?

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6140
>      if (!m_isSuspended)
> -	   return;
> -    m_drawingArea = nullptr;
> +	   m_shouldResetDrawingArea = true;
> +
> +    setLayerTreeStateIsFrozen(true);

Why does this now call setLayerTreeStateIsFrozen(true) even when unsuspending?