[webkit-reviews] review granted: [Bug 190887] Clean up some obsolete macOS version guards : [Attachment 353061] proposed patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Alexey Proskuryakov <ap at webkit.org>'s request for
review:
Bug 190887: Clean up some obsolete macOS version guards
https://bugs.webkit.org/show_bug.cgi?id=190887

Attachment 353061: proposed patch

https://bugs.webkit.org/attachment.cgi?id=353061&action=review




--- Comment #5 from mitz at webkit.org ---
Comment on attachment 353061
  --> https://bugs.webkit.org/attachment.cgi?id=353061
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353061&action=review

r=me

> Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:-333
> -#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101240

It’s not clear if we’re gaining anything at this point from changing the code
from “as shipped and tested” to “as intended”. For clarity and safety, we could
just change this to < 101300.