[webkit-reviews] review requested: [Bug 190887] Clean up some obsolete macOS version guards : [Attachment 353055] proposed patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 190887: Clean up some obsolete macOS version guards
https://bugs.webkit.org/show_bug.cgi?id=190887

Attachment 353055: proposed patch

https://bugs.webkit.org/attachment.cgi?id=353055&action=review




--- Comment #1 from Alexey Proskuryakov <ap at webkit.org> ---
Created attachment 353055

  --> https://bugs.webkit.org/attachment.cgi?id=353055&action=review

proposed patch

This should be no-op, except for the change in
Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in.

In that file, we have some rules guarded with "__MAC_OS_X_VERSION_MIN_REQUIRED
< 101240". MIN_REQUIRED doesn't change with SDK, so the code was actually still
built on macOS Sierra even after 10.12.4 update. But looks like the intention
was that it wouldn't be included, so I removed it.