[webkit-reviews] review granted: [Bug 190736] Attachment filenames with RTL characters should format similar to Finder : [Attachment 352733] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 24 14:09:22 PDT 2018


mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 190736: Attachment filenames with RTL characters should format similar to
Finder
https://bugs.webkit.org/show_bug.cgi?id=190736

Attachment 352733: Patch

https://bugs.webkit.org/attachment.cgi?id=352733&action=review




--- Comment #3 from mitz at webkit.org ---
Comment on attachment 352733
  --> https://bugs.webkit.org/attachment.cgi?id=352733
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352733&action=review

> Source/WebCore/html/HTMLAttachmentElement.cpp:163
> +String HTMLAttachmentElement::attachmentTitleForDisplay() const

Not redundant at all.


More information about the webkit-reviews mailing list