[webkit-reviews] review granted: [Bug 190859] Web Inspector: popovers for function source code are malformed : [Attachment 353016] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 24 12:19:38 PDT 2018


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 190859: Web Inspector: popovers for function source code are malformed
https://bugs.webkit.org/show_bug.cgi?id=190859

Attachment 353016: Patch

https://bugs.webkit.org/attachment.cgi?id=353016&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 353016
  --> https://bugs.webkit.org/attachment.cgi?id=353016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353016&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Popover.js:373
> +		   this._animationFrameIdentifier =
requestAnimationFrame(drawBackground.bind(this));

Can we add this to the constructor? I like to have all member variables defined
there when possible.

    this._animationFrameIdentifier = undefined;

> Source/WebInspectorUI/UserInterface/Views/Popover.js:381
> +	   cancelAnimationFrame(this._animationFrameIdentifier);

Preferably this would also clear the identifier:

    this._animationFrameIdentifier = undefined;


More information about the webkit-reviews mailing list