[webkit-reviews] review requested: [Bug 190878] Add BPLATFORM(IOS_FAMILY) : [Attachment 353038] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 24 10:19:03 PDT 2018


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 190878: Add BPLATFORM(IOS_FAMILY)
https://bugs.webkit.org/show_bug.cgi?id=190878

Attachment 353038: proposed patch

https://bugs.webkit.org/attachment.cgi?id=353038&action=review




--- Comment #1 from Alexey Proskuryakov <ap at webkit.org> ---
Created attachment 353038

  --> https://bugs.webkit.org/attachment.cgi?id=353038&action=review

proposed patch

Mostly mechanical. It may be worth verifying if BUSE_CHECK_NANO_MALLOC and
GIGACAGE_ENABLED are defined correctly. I believe that I kept the behavior
unchanged, but it's surprising that gigacage is only enabled on iOS proper.

 #if ((BOS(DARWIN) || BOS(LINUX)) && \
-    (BCPU(X86_64) || (BCPU(ARM64) && !defined(__ILP32__) && (!BPLATFORM(IOS)
|| __IPHONE_OS_VERSION_MIN_REQUIRED >= 110300))))
+    (BCPU(X86_64) || (BCPU(ARM64) && !defined(__ILP32__) &&
(!BPLATFORM(IOS_FAMILY) || BPLATFORM(IOS)))))
 #define GIGACAGE_ENABLED 1


More information about the webkit-reviews mailing list