[webkit-reviews] review granted: [Bug 190846] [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list : [Attachment 353018] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 24 09:30:00 PDT 2018


Antti Koivisto <koivisto at iki.fi> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 190846: [PSON] When navigating back and forth, 'about:blank' shows up in
the back/forward list
https://bugs.webkit.org/show_bug.cgi?id=190846

Attachment 353018: Patch

https://bugs.webkit.org/attachment.cgi?id=353018&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 353018
  --> https://bugs.webkit.org/attachment.cgi?id=353018
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353018&action=review

> Source/WebCore/loader/FrameLoader.cpp:3368
> +	   if (shouldContinue == ShouldContinue::ForSuspension) {
> +	       m_loadType = FrameLoadType::Standard;
>	      
m_provisionalDocumentLoader->willContinueMainResourceLoadAfterRedirect({
blankURL() });

Might be good to add a comment explaining why the load type is set to Standard.


More information about the webkit-reviews mailing list