[webkit-reviews] review granted: [Bug 190328] [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode : [Attachment 353025] patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 190328: [WPE] Fix CMake rules in for TestWebKitAPIBase library building in
developer mode
https://bugs.webkit.org/show_bug.cgi?id=190328

Attachment 353025: patch

https://bugs.webkit.org/attachment.cgi?id=353025&action=review




--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 353025
  --> https://bugs.webkit.org/attachment.cgi?id=353025
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353025&action=review

Looks good, just please change the casing of the variable names. I see the
style is a bit inconsistent in this file, but generally we use this style:

> Tools/TestWebKitAPI/CMakeLists.txt:88
> +    set(test_webKit_api_base_LIBRARIES

TestWebKitAPIBase_LIBRARIES

> Tools/TestWebKitAPI/CMakeLists.txt:95
> +    set(test_webKit_api_base_SOURCES

TestWebKitAPIBase_SOURCES