[webkit-reviews] review granted: [Bug 190865] [WPE][GTK] Cleanups to the certificate encoder : [Attachment 353028] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 190865: [WPE][GTK] Cleanups to the certificate encoder
https://bugs.webkit.org/show_bug.cgi?id=190865

Attachment 353028: Patch

https://bugs.webkit.org/attachment.cgi?id=353028&action=review




--- Comment #4 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 353028
  --> https://bugs.webkit.org/attachment.cgi?id=353028
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353028&action=review

> Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp:63
> +	   GByteArray* certificateData = 0;
>	   g_object_get(G_OBJECT(certificate), "certificate", &certificateData,
NULL);

`nullptr` should be used in both lines.

> Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp:80
> +	   GRefPtr<GByteArray> certificate = certificatesDataList[i - 1];

This takes an extra reference to the GByteArray pointer stored in the Vector.
Use auto& to bind a C++ reference to the existing GRefPtr instead:
    `auto& certificate = ...`