[webkit-reviews] review granted: [Bug 190761] [Win] Add function call name information to stack traces : [Attachment 353003] Updated Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has granted Christopher Reid
<chris.reid at sony.com>'s request for review:
Bug 190761: [Win] Add function call name information to stack traces
https://bugs.webkit.org/show_bug.cgi?id=190761

Attachment 353003: Updated Patch

https://bugs.webkit.org/attachment.cgi?id=353003&action=review




--- Comment #11 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 353003
  --> https://bugs.webkit.org/attachment.cgi?id=353003
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353003&action=review

Looks good to me.

> Source/WTF/ChangeLog:10
> +	       - application's working directory

It soulds like it means BuildBot Layout Tests can't show the function names by
this patch because it is executed from top directory while the build artifact
is placed in 'build' dir.