[webkit-reviews] review granted: [Bug 190818] Fix false positive leaks when using custom -init methods that don't start with -init : [Attachment 352953] Patch v1

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted David Kilzer (:ddkilzer) <ddkilzer at webkit.org>'s
request for review:
Bug 190818: Fix false positive leaks when using custom -init methods that don't
start with -init
https://bugs.webkit.org/show_bug.cgi?id=190818

Attachment 352953: Patch v1

https://bugs.webkit.org/attachment.cgi?id=352953&action=review




--- Comment #2 from mitz at webkit.org ---
Comment on attachment 352953
  --> https://bugs.webkit.org/attachment.cgi?id=352953
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=352953&action=review

> Source/WebKitLegacy/mac/Misc/WebKitErrorsPrivate.h:65
> +- (id)_webkit_initWithDomain:(NSString *)domain code:(int)code URL:(NSURL
*)URL __attribute__((objc_method_family(init)));

Can you add this declaration to a class extension in the .m file instead of the
private @interface in the header file? There’s no reason to expose this
internal detail in a header.