[webkit-reviews] review granted: [Bug 190827] TextTrack cues should be updated more often than every 250ms. : [Attachment 352975] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 23 08:12:11 PDT 2018
Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 190827: TextTrack cues should be updated more often than every 250ms.
https://bugs.webkit.org/show_bug.cgi?id=190827
Attachment 352975: Patch
https://bugs.webkit.org/attachment.cgi?id=352975&action=review
--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 352975
--> https://bugs.webkit.org/attachment.cgi?id=352975
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=352975&action=review
> Source/WebCore/platform/graphics/MediaPlayer.cpp:1540
> +bool MediaPlayer::performTaskAtMediaTime(WTF::Function<void()>&& task,
MediaTime time)
Nit: the return bool isn't used anywhere, is it necessary?
More information about the webkit-reviews
mailing list