[webkit-reviews] review granted: [Bug 190789] [WPE][GTK] Pass full certificate chain in CertificateInfo coder : [Attachment 352964] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 190789: [WPE][GTK] Pass full certificate chain in CertificateInfo coder
https://bugs.webkit.org/show_bug.cgi?id=190789

Attachment 352964: Patch

https://bugs.webkit.org/attachment.cgi?id=352964&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 352964
  --> https://bugs.webkit.org/attachment.cgi?id=352964
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352964&action=review

Wow, it's a good do-while loop. Don't see those very often.

> Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp:85
> +    // Encode starting from the root certificate.
> +    for (uint32_t i = chainLength; i > 0; i--) {
> +	   GRefPtr<GByteArray> certificate = adoptGRef(certificatesDataList[i -
1]);
> +	  
encoder.encodeVariableLengthByteArray(IPC::DataReference(certificate->data,
certificate->len));
>      }

Eh, maybe it *was* nicer the other way around... whatever, either order is
totally fine, as you prefer.