[webkit-reviews] review granted: [Bug 190814] HashMap should support selecting a random entry : [Attachment 352937] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 190814: HashMap should support selecting a random entry
https://bugs.webkit.org/show_bug.cgi?id=190814

Attachment 352937: Patch

https://bugs.webkit.org/attachment.cgi?id=352937&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 352937
  --> https://bugs.webkit.org/attachment.cgi?id=352937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352937&action=review

r=me

> Source/WTF/ChangeLog:8
> +	   In some cases, remove(begin()) is not quite good enough as a random

We also need to audit all sites that are currently using this pattern.