[webkit-reviews] review granted: [Bug 190777] [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails : [Attachment 352867] Fix DRT build
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 22 11:53:33 PDT 2018
Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 190777: [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
https://bugs.webkit.org/show_bug.cgi?id=190777
Attachment 352867: Fix DRT build
https://bugs.webkit.org/attachment.cgi?id=352867&action=review
--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 352867
--> https://bugs.webkit.org/attachment.cgi?id=352867
Fix DRT build
View in context: https://bugs.webkit.org/attachment.cgi?id=352867&action=review
> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:806
> + if ([NSStringFromClass(window.class)
isEqualToString:@"UIRemoteKeyboardWindow"])
Feels weird that this is a string compare instead of a class compare (store
NSClassFromString("UIRemoteKeyboardWindow") at the top of the function and
compare against that). But it also does not matter at all.
More information about the webkit-reviews
mailing list