[webkit-reviews] review granted: [Bug 190796] Deque's contains() and findIf() should be const : [Attachment 352895] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 22 11:31:41 PDT 2018


Antti Koivisto <koivisto at iki.fi> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 190796: Deque's contains() and findIf() should be const
https://bugs.webkit.org/show_bug.cgi?id=190796

Attachment 352895: Patch

https://bugs.webkit.org/attachment.cgi?id=352895&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 352895
  --> https://bugs.webkit.org/attachment.cgi?id=352895
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352895&action=review

> Source/WTF/wtf/Deque.h:407
> +    return std::find_if(begin(), end(), predicate);

Considering how few clients this stuff has, maybe they could just do this
themselves.


More information about the webkit-reviews mailing list