[webkit-reviews] review granted: [Bug 190757] Make synchronous IPC introduced in r237267 asynchronous : [Attachment 352807] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 190757: Make synchronous IPC introduced in r237267 asynchronous
https://bugs.webkit.org/show_bug.cgi?id=190757

Attachment 352807: Patch

https://bugs.webkit.org/attachment.cgi?id=352807&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 352807
  --> https://bugs.webkit.org/attachment.cgi?id=352807
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352807&action=review

Looks good but I have one concern about the autorelease.

> Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:584
> +	   completionHandler(array);

Any reason you dropped the autorelease?