[webkit-reviews] review granted: [Bug 190792] topPrivatelyControlledDomain is slow : [Attachment 352890] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 22 07:27:38 PDT 2018


Alex Christensen <achristensen at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 190792: topPrivatelyControlledDomain is slow
https://bugs.webkit.org/show_bug.cgi?id=190792

Attachment 352890: patch

https://bugs.webkit.org/attachment.cgi?id=352890&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 352890
  --> https://bugs.webkit.org/attachment.cgi?id=352890
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352890&action=review

> Source/WebCore/platform/mac/PublicSuffixMac.mm:51
> +    static NeverDestroyed<HashMap<String, AtomicString,
ASCIICaseInsensitiveHash>> cache;

Is there really a benefit to using AtomicString here?


More information about the webkit-reviews mailing list