[webkit-reviews] review granted: [Bug 190642] MediaRecorder should fire a stop event when all tracks are ended : [Attachment 352789] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Wendy <yuhan_wu at apple.com>'s
request for review:
Bug 190642: MediaRecorder should fire a stop event when all tracks are ended
https://bugs.webkit.org/show_bug.cgi?id=190642

Attachment 352789: Patch

https://bugs.webkit.org/attachment.cgi?id=352789&action=review




--- Comment #13 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 352789
  --> https://bugs.webkit.org/attachment.cgi?id=352789
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352789&action=review

>
LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-s
top.html:10
> +<canvas id="canvas">

Apparently, Firefox does not like capturing canvas without size.
Can you test it on Firefox and try adding width/height to see whether that
would make it work if not already?