[webkit-reviews] review granted: [Bug 190746] Introduce CompletionHandler-based Async IPC messages with replies : [Attachment 352783] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 19 10:25:54 PDT 2018
Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 190746: Introduce CompletionHandler-based Async IPC messages with replies
https://bugs.webkit.org/show_bug.cgi?id=190746
Attachment 352783: Patch
https://bugs.webkit.org/attachment.cgi?id=352783&action=review
--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 352783
--> https://bugs.webkit.org/attachment.cgi?id=352783
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=352783&action=review
> Source/WebKit/ChangeLog:11
> + What a mess. No wonder people take shortcuts and make strange
design decisions.
Hah. Ouch.
> Source/WebKit/ChangeLog:15
> + layout test and many others. I intent to refine and further adopt
this incrementally.
You intent!
> Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in:59
> + GetSandboxExtensionsForBlobFiles(Vector<String> paths) ->
(WebKit::SandboxExtension::HandleArray extensions) Async
I feel like we should either invert the sync-by-default or make you always
write one or the other. But that can be later.
More information about the webkit-reviews
mailing list